RFR: 8323605: Java source launcher should not require `--source ...` to enable preview [v4]

[David Holmes]

On Mon, 4 Mar 2024 08:18:25 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this PR targeting the source launcher that instead of throwing an error reading _"--enable-preview must be used with --source"_ adds the required compiler arguments on-the-fly.
>> 
>> The add arguments are `--release` and `feature`, with `feature` being the release feature number of the current Java runtime as acquired by `Runtime.version().feature()`.
>
> Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Update `java`'s man page
>  - Merge branch 'refs/heads/master' into JDK-8323605-launch-with-source-by-default
>  - Remove now outdated workaround
>    
>    [skip ci]
>  - Update copyright dates
>    
>    [skip ci]
>  - 8323605: Java source launcher should not require `--source ...` to enable preview

src/java.base/share/man/java.1 line 284:

> 282: If \f[V]--enable-preview\f[R] is specified, the \f[V]--source N\f[R]
> 283: arguments can be omitted.
> 284: The Java Runtime of version \f[V]N\f[R] implies an implicit

I think that should be `A Java runtime version ...`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17731#discussion_r1518990161