RFR: 8323605: Java source launcher should not require `--source ...` to enable preview [v4]

David Holmes dholmes at openjdk.org
Sun Mar 10 21:53:56 UTC 2024


On Sun, 10 Mar 2024 21:44:03 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Update `java`'s man page
>>  - Merge branch 'refs/heads/master' into JDK-8323605-launch-with-source-by-default
>>  - Remove now outdated workaround
>>    
>>    [skip ci]
>>  - Update copyright dates
>>    
>>    [skip ci]
>>  - 8323605: Java source launcher should not require `--source ...` to enable preview
>
> src/java.base/share/man/java.1 line 284:
> 
>> 282: If \f[V]--enable-preview\f[R] is specified, the \f[V]--source N\f[R]
>> 283: arguments can be omitted.
>> 284: The Java Runtime of version \f[V]N\f[R] implies an implicit
> 
> I think that should be `A Java runtime version ...`

Also `implies an implicit` is doubling up. I suggest the following complete sentence:

If the Java runtime version is N, then `--release N` is implied when compiling source files.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17731#discussion_r1518991164


More information about the compiler-dev mailing list