RFR: 8332226: "Invalid package name:" from source launcher [v2]

[Christian Stein]

On Mon, 20 May 2024 15:05:40 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Copy `ModulePath`'s exploded directories logic
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/ProgramDescriptor.java line 47:
> 
>> 45: 
>> 46: import javax.lang.model.SourceVersion;
>> 47: import jdk.internal.module.Checks;
> 
> I'm trying to page in the build steps for jdk.compiler.interim. It this compiled with the boot JDK or the newly built JDK or both? I'm just wondering if this dependency on the internal class will be problematic or not, also wondering if it would be better for toPackageName test with SourceVersion.isIdentifier(name) instead.

IIRC, `jdk.compiler` follows the N-1 rule, meaning that it and also ` jdk.compiler.interim` should be built with the boot JDK.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19245#discussion_r1608649591