RFR: 8332226: "Invalid package name:" from source launcher [v2]

[Christian Stein]

On Tue, 21 May 2024 16:50:34 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/ProgramDescriptor.java line 47:
>> 
>>> 45: 
>>> 46: import javax.lang.model.SourceVersion;
>>> 47: import jdk.internal.module.Checks;
>> 
>> I'm trying to page in the build steps for jdk.compiler.interim. It this compiled with the boot JDK or the newly built JDK or both? I'm just wondering if this dependency on the internal class will be problematic or not, also wondering if it would be better for toPackageName test with SourceVersion.isIdentifier(name) instead.
>
> IIRC, `jdk.compiler` follows the N-1 rule, meaning that it and also ` jdk.compiler.interim` should be built with the boot JDK.

>[...] also wondering if it would be better for toPackageName test with SourceVersion.isIdentifier(name) instead.

The initial commit of the PR does use `SourceVersion.isIdentifier(name)` and does not introduce an extra dependence on `jdk.internal.module`. See  https://github.com/openjdk/jdk/pull/19245/commits/ba9c886975ea8990774e237f6fdc03b441297e66 for details.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19245#discussion_r1608653177