RFR: 8332226: "Invalid package name:" from source launcher [v2]

Tue May 21 19:23:01 UTC 2024

On Tue, 21 May 2024 17:26:02 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>>>[...] also wondering if it would be better for toPackageName test with SourceVersion.isIdentifier(name) instead.
>> 
>> The initial commit of the PR does use `SourceVersion.isIdentifier(name)` and does not introduce an extra dependence on `jdk.internal.module`. See  https://github.com/openjdk/jdk/pull/19245/commits/ba9c886975ea8990774e237f6fdc03b441297e66 for details.
>
> We can't guarantee that jdk.internal.module.Checks will be stable across releases so dropping that dependency would be good.

Even with `exports jdk.internal.module to jdk.compiler` already in place before this change?

https://github.com/openjdk/jdk/blob/52eda79522a5bd71b527e5946b654a331b021473/src/java.base/share/classes/module-info.java#L227-L231

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19245#discussion_r1608847469