RFR: 8332226: "Invalid package name:" from source launcher [v2]

[Alan Bateman]

On Tue, 21 May 2024 16:53:11 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> IIRC, `jdk.compiler` follows the N-1 rule, meaning that it and also ` jdk.compiler.interim` should be built with the boot JDK.
>
>>[...] also wondering if it would be better for toPackageName test with SourceVersion.isIdentifier(name) instead.
> 
> The initial commit of the PR does use `SourceVersion.isIdentifier(name)` and does not introduce an extra dependence on `jdk.internal.module`. See  https://github.com/openjdk/jdk/pull/19245/commits/ba9c886975ea8990774e237f6fdc03b441297e66 for details.

We can't guarantee that jdk.internal.module.Checks will be stable across releases so dropping that dependency would be good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19245#discussion_r1608690551