RFR: 8331348: Some incremental builds deposit files in the make directory
Nizar Benalla
nbenalla at openjdk.org
Wed May 22 01:45:21 UTC 2024
Please review this small change.
In case of fatal errors or if a hidden option is passed to the compiler, a report with the parameters passed to it is printed to a file in the `@-file` format, this makes it easier for us to reproduce the bug. And for users submitting bug reports.
Some of these files were being deposited in the current directory during OpenJDK builds, now they are moved to the temp dir.
Writing to the console only is not an option because of the large number of arguments that can be passed to the compiler.
By convention, a number of arguments is printed to the console if an error occurs while writing to the file.
Some also suggested adding a message as to why this file exist.
TIA
I see the bot is complaining due to the fix version but I think it can be changed, if this is approved.
-------------
Commit messages:
- Matthias suggested writing into the files, why they were created.
- javac crash report should be created in tmpdir
Changes: https://git.openjdk.org/jdk/pull/19338/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19338&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8331348
Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/19338.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19338/head:pull/19338
PR: https://git.openjdk.org/jdk/pull/19338
More information about the compiler-dev
mailing list