RFR: 8331348: Some incremental builds deposit files in the make directory

Magnus Ihse Bursie ihse at openjdk.org
Wed May 22 07:04:12 UTC 2024


On Wed, 22 May 2024 00:33:44 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Please review this small change.
> 
> In case of fatal errors or if a hidden option is passed to the compiler, a report with the parameters passed to it is printed to a file in the `@-file` format, this makes it easier for us to reproduce the bug. And for users submitting bug reports.
> Some of these files were being deposited in the current directory during OpenJDK builds, now they are moved to the temp dir.
> Writing to the console only is not an option because of the large number of arguments that can be passed to the compiler.
> By convention, a number of arguments is printed to the console if an error occurs while writing to the file.
> Some also suggested adding a message as to why this file exist.
> 
> TIA
> 
> I see the bot is complaining due to the fix version but I think it can be changed, if this is approved.

Please close one of the bug issues as a dup rather than adding an additional issue here, thanks.

As far as I am aware, we do not set `java.io.tmpdir` in the build system. What will it default to? Have you verified that this actually solves the problem?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19338#issuecomment-2124017117
PR Comment: https://git.openjdk.org/jdk/pull/19338#issuecomment-2124018662


More information about the compiler-dev mailing list