RFR: 8332226: "Invalid package name:" from source launcher [v4]

[Alan Bateman]

On Fri, 24 May 2024 09:02:29 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this change excluding directory paths with invalid elements when computing the packages of a module in source-launch mode.
>> 
>> Note that this inital iteration of the change only fixes the in-memory computation of package names - the behaviour of the associated module reader implementation is untouched for the time being. This introduces a difference in the set of resources being readable at runtime. For example, see the modified test case: the new and invalid `.bar` directory doesn't show up in the contents of the module - but it is reported by the module reader's `list()` method.
>> 
>> Note additionally, that above's behaviour is also observed for compiled and exploded modules. Meaning, that with this change being applied, the source mode and compiled mode of the launcher are in line.
>
> Christian Stein has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Drop use of internal module
>  - Reapply "Copy `ModulePath`'s exploded directories logic"
>    
>    This reverts commit 709f4ad3e4bd524d36857e689ec716b30d9024df.

Aligns source launcher with runtime without dependency on internal API so I think this looks okay.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19245#pullrequestreview-2076351513