Integrated: 8332226: "Invalid package name:" from source launcher
Christian Stein
cstein at openjdk.org
Fri May 24 12:27:11 UTC 2024
On Wed, 15 May 2024 07:48:09 GMT, Christian Stein <cstein at openjdk.org> wrote:
> Please review this change excluding directory paths with invalid elements when computing the packages of a module in source-launch mode.
>
> Note that this inital iteration of the change only fixes the in-memory computation of package names - the behaviour of the associated module reader implementation is untouched for the time being. This introduces a difference in the set of resources being readable at runtime. For example, see the modified test case: the new and invalid `.bar` directory doesn't show up in the contents of the module - but it is reported by the module reader's `list()` method.
>
> Note additionally, that above's behaviour is also observed for compiled and exploded modules. Meaning, that with this change being applied, the source mode and compiled mode of the launcher are in line.
This pull request has now been integrated.
Changeset: f16265d6
Author: Christian Stein <cstein at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/f16265d69b09640b972b7494ad57158dbdc426bb
Stats: 67 lines in 2 files changed: 47 ins; 0 del; 20 mod
8332226: "Invalid package name:" from source launcher
Reviewed-by: alanb
-------------
PR: https://git.openjdk.org/jdk/pull/19245
More information about the compiler-dev
mailing list