RFR: 8332858: References with escapes have broken positions after they are transformed [v2]

Jan Lahoda jlahoda at openjdk.org
Wed May 29 11:50:14 UTC 2024


> If the javadoc comment contains a (Markdown) link like:
> 
> [java.util.Arrays#asList(Object[])]
> 
> 
> The transformer that converts this link into the Javadoc link will not find the reference, as it is looking for `java.util.Arrays#asList(Object[])` (note the missing escapes), which is not present in the original text.
> 
> This patch tries to fix that by permitting optional escapes for all escapable character when searching for the reference, in case the literal search fails. This is done using regexp, although could presumably be done using a manual search.

Jan Lahoda has updated the pull request incrementally with two additional commits since the last revision:

 - Fixing incorrect position.
 - Adjusting according to the review suggestions.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19387/files
  - new: https://git.openjdk.org/jdk/pull/19387/files/b75f896f..5871d111

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19387&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19387&range=00-01

  Stats: 20 lines in 1 file changed: 0 ins; 15 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/19387.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19387/head:pull/19387

PR: https://git.openjdk.org/jdk/pull/19387


More information about the compiler-dev mailing list