RFR: 8332858: References with escapes have broken positions after they are transformed [v2]

Jonathan Gibbons jjg at openjdk.org
Wed May 29 23:00:02 UTC 2024


On Wed, 29 May 2024 11:50:14 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> If the javadoc comment contains a (Markdown) link like:
>> 
>> [java.util.Arrays#asList(Object[])]
>> 
>> 
>> The transformer that converts this link into the Javadoc link will not find the reference, as it is looking for `java.util.Arrays#asList(Object[])` (note the missing escapes), which is not present in the original text.
>> 
>> This patch tries to fix that by permitting optional escapes for all escapable character when searching for the reference, in case the literal search fails. This is done using regexp, although could presumably be done using a manual search.
>
> Jan Lahoda has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fixing incorrect position.
>  - Adjusting according to the review suggestions.

Marked as reviewed by jjg (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19387#pullrequestreview-2086775311


More information about the compiler-dev mailing list