RFR: 8333131: Source launcher should work with service loader SPI [v3]

[Jonathan Gibbons]

On Wed, 29 May 2024 07:32:27 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this fix for the memory class loader to find classes defined by a modular source program; including classes referenced in its module descriptor.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove trailing space characters

Marked as reviewed by jjg (Reviewer).

test/langtools/tools/javac/launcher/ModuleSourceLauncherTests.java line 235:

> 233: 
> 234:                 class Main {
> 235:                     public static void main(String... args) throws Exception {

Stylistically, it can be neater to abstract the use of `System.out` to avoid repeated use of the field.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19443#pullrequestreview-2091010248
PR Review Comment: https://git.openjdk.org/jdk/pull/19443#discussion_r1622519114