RFR: 8333131: Source launcher should work with service loader SPI [v3]
Christian Stein
cstein at openjdk.org
Fri May 31 15:10:06 UTC 2024
On Fri, 31 May 2024 14:34:10 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove trailing space characters
>
> test/langtools/tools/javac/launcher/ModuleSourceLauncherTests.java line 235:
>
>> 233:
>> 234: class Main {
>> 235: public static void main(String... args) throws Exception {
>
> Stylistically, it can be neater to abstract the use of `System.out` to avoid repeated use of the field.
The intention here was to use a few idiomatic lines known from many simple Java programs. "Copy and paste" turned into a larger pattern then expected: will use a shorter form in the future. Either using a field or `IO.println()` in combination with an `import static java.io.IO.println;`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19443#discussion_r1622567756
More information about the compiler-dev
mailing list