RFR: 8342967: Lambda deduplication fails with non-metafactory BSMs and mismatched local variables names [v2]

Aggelos Biboudis abimpoudis at openjdk.org
Thu Oct 24 22:14:40 UTC 2024


> After experimentation and under certain conditions, a few equivalent lambdas (up to variable renaming) fail to deduplicate.
> 
> `TreeHasher` and `TreeDiffer` are now aware that other bootstraps may appear in lambda bodies (e.g. `SwitchBootstraps.typeSwitch`) and that variable names do not matter (when they appear in method/lambda definitions). In the first case equivalence is checked based on `bsmKey` and not the `Dynamic{Var, Method}Symbol` itself.
> 
> The test was also adjusted since it was assuming BSM with certain structure only (that `.get(1)` was unprotected).

Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:

  Address review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21687/files
  - new: https://git.openjdk.org/jdk/pull/21687/files/e7a6c041..4b0d560b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21687&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21687&range=00-01

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21687.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21687/head:pull/21687

PR: https://git.openjdk.org/jdk/pull/21687


More information about the compiler-dev mailing list