RFR: 8342967: Lambda deduplication fails with non-metafactory BSMs and mismatched local variables names [v2]

[Aggelos Biboudis]

On Thu, 24 Oct 2024 16:46:02 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TreeDiffer.java line 224:
> 
>> 222:         Symbol otherSymbol = that.sym;
>> 223: 
>> 224:         result &= scan(symbol, otherSymbol);
> 
> I think we want to short circuit here, and `&=` will evaluate `scan` even if `result` is already `false`.
> Suggestion:
> 
>         if (result)
>             result = scan(symbol, otherSymbol);

Thanks! Done!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21687#discussion_r1815760533