RFR: 8342967: Lambda deduplication fails with non-metafactory BSMs and mismatched local variables names [v2]

[Vicente Romero]

On Fri, 25 Oct 2024 15:34:41 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

> > side: not sure if the dedup effort is worthy at the end in terms of performance / class file reduction / maintenance
> 
> Good point - these deduplication tests are rather painful to maintain every time the compiler is changed (I had to fight with them as well when writing the revamped backend support for flexible constructor bodies). I share the general feeling of a slightly negative cost vs. benefit ratio -- but I don't have any backing evidence (maybe we should gather that up).

it seems like for some code bases it makes sense, which is I think why Liam proposed this change, but this type of optimization seems to belong more to the VM than to javac

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21687#issuecomment-2438146305