RFR: 8342967: Lambda deduplication fails with non-metafactory BSMs and mismatched local variables names [v2]

[Aggelos Biboudis]

On Fri, 25 Oct 2024 15:11:50 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> side: not sure if the dedup effort is worthy at the end in terms of performance / class file reduction / maintenance
>
>> side: not sure if the dedup effort is worthy at the end in terms of performance / class file reduction / maintenance
> 
> Good point - these deduplication tests are rather painful to maintain every time the compiler is changed (I had to fight with them as well when writing the revamped backend support for flexible constructor bodies). I share the general feeling of a slightly negative cost vs. benefit ratio -- but I don't have any backing evidence (maybe we should gather that up).

I addressed the review. One thing that I didn't yet change is `visitVarDef` after @mcimadamore's https://github.com/openjdk/jdk/pull/21687#discussion_r1816527035

@cushon what do you think?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21687#issuecomment-2441699015