RFR: 8342967: Lambda deduplication fails with non-metafactory BSMs and mismatched local variables names [v2]

[Vicente Romero]

On Thu, 24 Oct 2024 22:14:40 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

>> After experimentation and under certain conditions, a few equivalent lambdas (up to variable renaming) fail to deduplicate.
>> 
>> `TreeHasher` and `TreeDiffer` are now aware that other bootstraps may appear in lambda bodies (e.g. `SwitchBootstraps.typeSwitch`) and that variable names do not matter (when they appear in method/lambda definitions). In the first case equivalence is checked based on `bsmKey` and not the `Dynamic{Var, Method}Symbol` itself.
>> 
>> The test was also adjusted since it was assuming BSM with certain structure only (that `.get(1)` was unprotected).
>
> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review

I was reading the discussion back then and it seems like the number of lambdas that could be deduplicated per file were < 1 on average, this is for their code base. We are not de-duplicating serializable lambdas and if we are generating debug info, then we are not deduplicating either

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21687#issuecomment-2438215969