RFR: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds [v2]

[Jan Lahoda]

On Tue, 3 Sep 2024 14:43:54 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reflecting review feedback - adjusting javadoc and name.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 1030:
> 
>> 1028:          * $record($prefix$, $resultOfReduction, $suffix$)
>> 1029:          *
>> 1030:          * useHashes: when true, patterns will be a subject to exact equivalence;
> 
> - will be ~a~ subject
> - two binding~s~ patterns

Done, thanks!

> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 1067:
> 
>> 1065:                              //error recovery, ignore patterns with incorrect number of nested patterns:
>> 1066:                              .filter(pd -> pd.nested.length == nestedPatternsCount)
>> 1067:                              .collect(groupingBy(pd -> useHashes ? pd.hashCode(mismatchingCandidateFin) : 0));
> 
> `groupByHashes` can be renamed into `groupByOnlyMismatchingCandidateDifference` or something else. The `ByHashes` is not applicable any more in the general case.

I've used `groupEquivalenceCandidates` - please let me know if that makes sense.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20836#discussion_r1746629314
PR Review Comment: https://git.openjdk.org/jdk/pull/20836#discussion_r1746628898