RFR: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds [v2]

Aggelos Biboudis abimpoudis at openjdk.org
Fri Sep 6 08:09:51 UTC 2024


On Fri, 6 Sep 2024 07:23:25 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 1067:
>> 
>>> 1065:                              //error recovery, ignore patterns with incorrect number of nested patterns:
>>> 1066:                              .filter(pd -> pd.nested.length == nestedPatternsCount)
>>> 1067:                              .collect(groupingBy(pd -> useHashes ? pd.hashCode(mismatchingCandidateFin) : 0));
>> 
>> `groupByHashes` can be renamed into `groupByOnlyMismatchingCandidateDifference` or something else. The `ByHashes` is not applicable any more in the general case.
>
> I've used `groupEquivalenceCandidates` - please let me know if that makes sense.

Perfect!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20836#discussion_r1746682939


More information about the compiler-dev mailing list