RFR: 8339852: Fix typos in java.compiler documentation [v2]

Joe Darcy darcy at openjdk.org
Fri Sep 13 21:17:05 UTC 2024


On Tue, 10 Sep 2024 21:54:35 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Please review this PR to fix typos and formatting issues. Some typos are trivial, others relate to domain vocabulary.
>
> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Dan's feedback

src/java.compiler/share/classes/javax/lang/model/SourceVersion.java line 499:

> 497:      * Character#isJavaIdentifierPart(int)} returns {@code true}.
> 498:      * This pattern matches regular identifiers, keywords, contextual
> 499:      * keywords, boolean literals, and the null literal.

I don't think it is necessarily more clear remove the explicit listing of the strings in question.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20937#discussion_r1759529077


More information about the compiler-dev mailing list