RFR: 8339852: Fix typos in java.compiler documentation [v2]
Pavel Rappo
prappo at openjdk.org
Fri Sep 13 21:31:09 UTC 2024
On Fri, 13 Sep 2024 21:14:39 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Dan's feedback
>
> src/java.compiler/share/classes/javax/lang/model/SourceVersion.java line 499:
>
>> 497: * Character#isJavaIdentifierPart(int)} returns {@code true}.
>> 498: * This pattern matches regular identifiers, keywords, contextual
>> 499: * keywords, boolean literals, and the null literal.
>
> I don't think it is necessarily more clear remove the explicit listing of the strings in question.
Perhaps. I just thought that it's strange to spell them out only here, but refer to them through "x literal(s)" everywhere else in that file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20937#discussion_r1759538760
More information about the compiler-dev
mailing list