RFR: 8340721: Clarify special case handling of unboxedType and getWildcardType [v2]

[Joe Darcy]

On Thu, 26 Sep 2024 10:10:11 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> src/java.compiler/share/classes/javax/lang/model/util/Types.java line 56:
> 
>> 54:  * In the reference implementation, handling {@linkplain ErrorType
>> 55:  * error types} generally does not cause an {@code
>> 56:  * UnsupportedOperationException} from the methods in this interface.
> 
> Did you really mean `UnsupportedOperationException` and not `IllegalArgumentException`?

Yes, meant IAE; will correct in the next push.

> test/langtools/tools/javac/processing/model/util/types/TestInvalidInputs.java line 171:
> 
>> 169:         for (TypeMirror tm : invalidInputs) {
>> 170:             try {
>> 171:                 WildcardType wc1 = types.getWildcardType(tm,   null);
> 
> Calling getWildcardType for an array type does not throw IAE; is this expected?

Will correct in next push; thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21193#discussion_r1777430381
PR Review Comment: https://git.openjdk.org/jdk/pull/21193#discussion_r1777432454