RFR: 8340721: Clarify special case handling of unboxedType and getWildcardType [v2]

Joe Darcy darcy at openjdk.org
Fri Sep 27 00:42:40 UTC 2024


On Thu, 26 Sep 2024 11:32:14 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> test/langtools/tools/javac/processing/model/util/types/TestInvalidInputs.java line 149:
> 
>> 147:             try {
>> 148:                 PrimitiveType pt = types.unboxedType(tm);
>> 149:             } catch(IllegalArgumentException iae) {
> 
> Here and elsewhere in this file: if some of the calls didn't throw IAE, the test would still pass. Is this your goal?

Good catch; corrected.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21193#discussion_r1777880972


More information about the compiler-dev mailing list