RFR: 8340721: Clarify special case handling of unboxedType and getWildcardType [v2]

Joe Darcy darcy at openjdk.org
Fri Sep 27 17:21:15 UTC 2024


On Fri, 27 Sep 2024 12:10:42 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> src/java.compiler/share/classes/javax/lang/model/util/Types.java line 280:
> 
>> 278:      *
>> 279:      * @throws IllegalArgumentException if bounds are not valid,
>> 280:      * including for types that are <em>not</em> {@linkplain ReferenceType
> 
> I find "including for types" hard to parse and connect to the previous clause. Did you mean "e.g. if if the bounds are not reference types" ?

Okay; I'll rephrase this to be more clear. Something like:

"throws IllegalArgumentException - if bounds are not valid. Invalid bounds include all types that are not reference types."

The intention of the phrasing is meant to imply there are reference type arguments that could be invalid, per any restrictions from the JLS. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21193#discussion_r1778927419


More information about the compiler-dev mailing list