RFR: 8340721: Clarify special case handling of unboxedType and getWildcardType [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Sep 27 12:13:37 UTC 2024


On Thu, 26 Sep 2024 16:48:17 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> First piece of a larger set of updates that may be made for JDK-8055219 to clarify the exceptional behavior of `javax.lang.model.util.Types`.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Respond to review feedback.

src/java.compiler/share/classes/javax/lang/model/util/Types.java line 280:

> 278:      *
> 279:      * @throws IllegalArgumentException if bounds are not valid,
> 280:      * including for types that are <em>not</em> {@linkplain ReferenceType

I find "including for types" hard to parse and connect to the previous clause. Did you mean "e.g. if if the bounds are not reference types" ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21193#discussion_r1778518313


More information about the compiler-dev mailing list