RFR: 8340721: Clarify special case handling of unboxedType and getWildcardType [v3]

Pavel Rappo prappo at openjdk.org
Fri Sep 27 19:15:36 UTC 2024


On Fri, 27 Sep 2024 08:58:52 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> test/langtools/tools/javac/processing/model/util/types/TestInvalidInputs.java line 164:
> 
>> 162:         // Reference types are ArrayType, DeclaredType, ErrorType, NullType, TypeVariable
>> 163:         // non-reference: ExecutableType, IntersectionType, NoType, PrimitiveType, UnionType, WildcardType
>> 164:         var invalidInputs = List.of( arrayType,
> 
> Do we need to change `getWildcardType`'s behaviour for `ArrayType` or specification? `ArrayType` is a reference type, and `getWildcardType` is now specified to throw IAE for all reference types.

Oops, disregard that previous comment. My bad, was sloppily reviewing this part.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21193#discussion_r1779050260


More information about the compiler-dev mailing list