RFR: 8340721: Clarify special case handling of unboxedType and getWildcardType [v3]

Joe Darcy darcy at openjdk.org
Fri Sep 27 20:43:36 UTC 2024


On Thu, 26 Sep 2024 10:35:36 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> test/langtools/tools/javac/processing/model/util/types/TestInvalidInputs.java line 51:
> 
>> 49:     private ArrayType        arrayType;
>> 50:     private DeclaredType     declaredType;
>> 51:     // private ErrorType        errorType; // skip for now
> 
> Any plans on how to test `ErrorType` in the future?

I think doing that reliably could take a bit of extra effort and need to step outside of the one-file-for-a-test methodology. For example, have an "Erroneous.java" test that was only compiled during the annotation processioning phase and not when the annotation processor itself is built.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21193#discussion_r1779133306


More information about the compiler-dev mailing list