RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v3]

Nizar Benalla nbenalla at openjdk.org
Thu Apr 24 15:55:36 UTC 2025


On Thu, 24 Apr 2025 15:45:48 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   place negative check in correct position
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java line 315:
> 
>> 313:             }
>> 314: 
>> 315:             // Handle overflow.
> 
> The overflow check below is now redundant. Would be nice to move the comment up to the new check.

Done. I kept it because I want to leave the rest of the method as-is, but I do agree that it can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24620#discussion_r2058767712


More information about the compiler-dev mailing list