RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v4]

Nizar Benalla nbenalla at openjdk.org
Thu Apr 24 15:55:34 UTC 2025


> Please review this patch to fix a potential infinite loop in `JavadocTokenizer.ensure` when `map.length` and `size + need` approach Interger.MAX_VALUE.
> 
> While I couldn't reproduce the issue even with large inputs (~1.9GB java file where almost the entire file is one javadoc comment), the fix is about correctness and prevention of UB in extreme cases.
> 
> TIA

Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:

  remove redundant overflow check

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24620/files
  - new: https://git.openjdk.org/jdk/pull/24620/files/88a5f499..c6d059bf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24620&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24620&range=02-03

  Stats: 5 lines in 1 file changed: 1 ins; 3 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/24620.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24620/head:pull/24620

PR: https://git.openjdk.org/jdk/pull/24620


More information about the compiler-dev mailing list