RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v4]

Hannes Wallnöfer hannesw at openjdk.org
Thu Apr 24 16:26:42 UTC 2025


On Thu, 24 Apr 2025 15:55:34 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Please review this patch to fix a potential infinite loop in `JavadocTokenizer.ensure` when `map.length` and `size + need` approach Interger.MAX_VALUE.
>> 
>> While I couldn't reproduce the issue even with large inputs (~1.9GB java file where almost the entire file is one javadoc comment), the fix is about correctness and prevention of UB in extreme cases.
>> 
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove redundant overflow check

Looks good!

-------------

Marked as reviewed by hannesw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24620#pullrequestreview-2791821003


More information about the compiler-dev mailing list