RFR: 8347474: Options singleton is used before options are parsed [v5]

[Vicente Romero]

On Thu, 16 Jan 2025 02:43:39 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> This PR proposes some cleanup/refactoring relating to startup ordering issues in the compiler.
>> 
>> Please see the follow-up comment for a more complete description (trying to keep the first comment short).
>
> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add some Javadoc/comment improvements to Lint.java.

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java line 146:

> 144:     // For the root instance only, these are initialized lazily
> 145:     private EnumSet<LintCategory> values;           // categories enabled by default or "-Xlint:key" and not (yet) suppressed
> 146:     private EnumSet<LintCategory> suppressedValues; // categories suppressed by augment() or suppress() (but not "-Xlint:-key")

I was not expecting to find so many changes in this class. From the description I was expecting most changes in Options and some "small" changes in its clients, not saying that this is wrong, just that probably the description should be augmented

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23056#discussion_r1919338981