RFR: 8347474: Options singleton is used before options are parsed [v5]

[Archie Cobbs]

On Thu, 16 Jan 2025 22:49:57 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add some Javadoc/comment improvements to Lint.java.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java line 146:
> 
>> 144:     // For the root instance only, these are initialized lazily
>> 145:     private EnumSet<LintCategory> values;           // categories enabled by default or "-Xlint:key" and not (yet) suppressed
>> 146:     private EnumSet<LintCategory> suppressedValues; // categories suppressed by augment() or suppress() (but not "-Xlint:-key")
> 
> I was not expecting to find so many changes in this class. From the description I was expecting most changes in Options and some "small" changes in its clients, not saying that this is wrong, just that probably the description should be augmented

Yep - those changes are mainly me trying to clean things up and improve the documentation and not directly related to this ticket.

I have another PR brewing that would be a better place for them so I'll revert those changes from this one - see 4e751f87d33.

Thanks for the feedback!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23056#discussion_r1919361305