RFR: 8348212: Need to add warn() step to JavacTaskImpl after JDK-8344148

[Maurizio Cimadamore]

On Tue, 21 Jan 2025 23:42:29 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> In [JDK-8344148](https://bugs.openjdk.org/browse/JDK-8344148) a new `warn()` compiler phase was added and `JavaCompiler.java` was updated accordingly.
> 
> However, the class `JavacTaskImpl` also walks through the compiler phases step-by-step, but the new `warn()` step was never added there. This will cause some warnings to not be emitted when that API is used.
> 
> This PR adds the missing `warn()` calls.

Looks good. Another possibility would be to couple warn with flow (note that `attribute` also calls the `postAttr` visitor, for instance -- e.g. there doesn't need to be an exact 1-1 mapping here).

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23223#pullrequestreview-2572404579