RFR: 8348212: Need to add warn() step to JavacTaskImpl after JDK-8344148 [v2]
Archie Cobbs
acobbs at openjdk.org
Fri Jan 24 16:23:15 UTC 2025
On Fri, 24 Jan 2025 11:33:08 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add a regression test.
>
> Looks good. Another possibility would be to couple warn with flow (note that `attribute` also calls the `postAttr` visitor, for instance -- e.g. there doesn't need to be an exact 1-1 mapping here).
@mcimadamore, thanks for the review!
I just realized this PR also should have a regression test - I've added one in c7b6fcb59f2.
You may need to re-review. Thanks!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23223#issuecomment-2612910582
More information about the compiler-dev
mailing list