RFR: 8358066: Non-ascii package names gives compilation error "import requires canonical name" [v2]
Archie Cobbs
acobbs at openjdk.org
Tue Jun 3 14:48:52 UTC 2025
On Tue, 3 Jun 2025 11:42:35 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> Looks good to me. (I didn't run tests, please ask if you would want me to run them.)
Thanks for the review!
Re: tests, to be honest I'm not sure what criteria to use to determine that. This change seems pretty innocuous but "seems" is a dangerous word. I'm happy to follow your advice on this... ? Thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25567#issuecomment-2935689691
More information about the compiler-dev
mailing list