RFR: 8358066: Non-ascii package names gives compilation error "import requires canonical name" [v2]

[Jan Lahoda]

On Tue, 3 Jun 2025 14:46:02 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> > Looks good to me. (I didn't run tests, please ask if you would want me to run them.)
> 
> Thanks for the review!
> 
> Re: tests, to be honest I'm not sure what criteria to use to determine that. This change seems pretty innocuous but "seems" is a dangerous word. I'm happy to follow your advice on this... ? Thanks.

I've started a test run, the results will hopefully be tomorrow (my time, CEST). I think we should wait with the integration before they run.

Alternatively you could issue `/integrate delegate`, and I'd finish the integration if the tests are OK. But I think there's still time before RDP1, so there's not (yet) a need to do this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25567#issuecomment-2936683820