RFR: 8356645: Javac should utilize new ZIP file system read-only access mode

[Jan Lahoda]

On Tue, 10 Jun 2025 13:29:50 GMT, David Beaumont <duke at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java line 565:
>> 
>>> 563:             this.archivePath = archivePath;
>>> 564:             // Common parameters for opening ZIP/JAR file systems in Javac.
>>> 565:             Map<String, ?> env = FSInfo.readOnlyJarFSEnv(multiReleaseValue);
>> 
>> Note that this will now cause `.zip` files to be treated the same as `.jar` files when `multiReleaseValue ≠ null` (previously, this was ignored for `.zip` files)
>
> That's an excellent point. I will be sure to ask people if that looks acceptable and revert to the original behaviour otherwise. Thank you for spotting it and saying something.

I think I would prefer to no send the multi release value for non-jar files - possibly there's no observable difference at this time, but the multi-release jar is for jars only.

(Also the comment above the variable seems a bit superfluous.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25639#discussion_r2139258325