RFR: 8356645: Javac should utilize new ZIP file system read-only access mode [v3]
David Beaumont
duke at openjdk.org
Wed Jun 18 20:32:13 UTC 2025
On Wed, 11 Jun 2025 05:45:48 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
>> That's an excellent point. I will be sure to ask people if that looks acceptable and revert to the original behaviour otherwise. Thank you for spotting it and saying something.
>
> I think I would prefer to no send the multi release value for non-jar files - possibly there's no observable difference at this time, but the multi-release jar is for jars only.
>
> (Also the comment above the variable seems a bit superfluous.)
Done. Though the more times I write `readOnlyJarFSEnv(null)` the more I think a no-arg version of that method might carry its weight.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25639#discussion_r2155432740
More information about the compiler-dev
mailing list