RFR: 8336470: Source launcher should work with service loader SPI in unnamed module [v16]

Christian Stein cstein at openjdk.org
Fri May 16 07:22:46 UTC 2025


> Please review this change adding a missing resource file test to the `MemoryClassLoader::findResource` override in order to resolve all files beneath the source root path in source launch mode - analog to what was already implemented for `MemoryClassLoader::getResource`.
> 
> With this change applied, files in `META-INF/services/` are resolved; allowing services providers being supplied in source form.

Christian Stein has updated the pull request incrementally with two additional commits since the last revision:

 - Improve classloader test
 - Handle IOError thrown by Path::toUri

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20193/files
  - new: https://git.openjdk.org/jdk/pull/20193/files/11956f24..bd60486a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20193&range=15
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20193&range=14-15

  Stats: 44 lines in 3 files changed: 33 ins; 5 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/20193.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20193/head:pull/20193

PR: https://git.openjdk.org/jdk/pull/20193


More information about the compiler-dev mailing list