RFR: 8336470: Source launcher should work with service loader SPI in unnamed module [v16]
Alan Bateman
alanb at openjdk.org
Fri May 16 08:07:55 UTC 2025
On Fri, 16 May 2025 07:22:46 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this change adding a missing resource file test to the `MemoryClassLoader::findResource` override in order to resolve all files beneath the source root path in source launch mode - analog to what was already implemented for `MemoryClassLoader::getResource`.
>>
>> With this change applied, files in `META-INF/services/` are resolved; allowing services providers being supplied in source form.
>
> Christian Stein has updated the pull request incrementally with two additional commits since the last revision:
>
> - Improve classloader test
> - Handle IOError thrown by Path::toUri
Latest version looks okay.
-------------
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20193#pullrequestreview-2845841524
More information about the compiler-dev
mailing list