Review request #1: 6863566 (Java should support the freedesktop.org startup notification specification)

Michael McMahon Michael.McMahon at Sun.COM
Thu Oct 15 15:10:03 UTC 2009


It doesn't seem right to filter out arbitrary environment variables
like that (inside ProcessEnvironment). Sorry, I haven't been following 
this issue closely,
but is it not possible to unset this variable somewhere else?

- Michael.

Alan Bateman wrote:
>
> Martin, Michael - have either of you looked at the filtering that they 
> are proposing to add to ProcessEnvironment?
>
>
> Anthony Petrov wrote:
>> Hello,
>>
>> Please review the next version of the fix contributed by Damjan 
>> Jovanovic:
>>
>> RFE: https://bugs.openjdk.java.net/show_bug.cgi?id=100094
>> There you can also find some latest comments regarding the fix.
>>
>> webrev:
>> http://cr.openjdk.java.net/~anthony/7-24-startupNotify-6863566.1/
>>
>> Since the patch includes changes to the 
>> src/solaris/classes/java/lang/ProcessEnvironment.java, I'm
>> CC'ing the Core Libs alias to review the changes in that file.
>>
>>
>> From AWT perspective, the changes look good to me.
>>
>> -- 
>> best regards,
>> Anthony
>




More information about the core-libs-dev mailing list