4206909 - adding Z_SYNC_FLUSH support to deflaters

David M. Lloyd david.lloyd at redhat.com
Sun Sep 13 15:49:50 UTC 2009


On 09/12/2009 04:45 PM, Martin Buchholz wrote:
> On Fri, Sep 11, 2009 at 16:13, Xueming Shen<Xueming.Shen at sun.com> wrote:
> David wrote:
>> This is not unusual in the JDK or elsewhere - that a stream calls the underlying stream's flush() method I mean - and I think in the (unlikely) event that someone wants to flush the underlying stream only, they could simply call .flush() directly on that stream.
> 
> David: In this case the deflater is not an "underlying stream", and the proposal was to
> have flush() change the nature of the bytes written, while normally OutputStream.flush merely causes
> the same bytes to be written more promptly.

In this paragraph I was referring to the real underlying OutputStream 
though, not the Deflater (afaict the existing implementation just calls 
through to the underlying stream currently).

The second paragraph is where I talk about the Deflater.  And anyway I 
change my vote from "yes-kinda-no-but-qualified-yes" in favor of the plan B 
patch which I like a lot.

- DML



More information about the core-libs-dev mailing list