Code review request for 7002594 "Math.max and Math.min should use floatToRawIntBits() to check for -0.0"

Lance Andersen - Oracle Lance.Andersen at oracle.com
Wed Dec 1 19:12:22 UTC 2010


Hi Joe,

Looks fine to me.

-lance
On Dec 1, 2010, at 12:24 PM, Joe Darcy wrote:

> Hello.
> 
> Please review my simple fix for
> 
>    7002594 "Math.max and Math.min should use floatToRawIntBits() to check for -0.0"
>    http://cr.openjdk.java.net/~darcy/7002594.0/
> 
> Besides addressing the reported issues with max/min, I also review the other uses of those methods in java.lang.* and added a comment or two.  While looking over sun/misc/FpUtils.java, I took the opportunity to update the javadoc style.
> 
> Thanks,
> 
> -Joe




Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com

	Oracle is committed to developing practices and products that help protect the environment


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/core-libs-dev/attachments/20101201/c463235a/attachment.html>


More information about the core-libs-dev mailing list