Code review request for 7002594 "Math.max and Math.min should use floatToRawIntBits() to check for -0.0"

Rémi Forax forax at univ-mlv.fr
Wed Dec 1 19:23:51 UTC 2010


On 12/01/2010 06:24 PM, Joe Darcy wrote:
> Hello.
>
> Please review my simple fix for
>
>     7002594 "Math.max and Math.min should use floatToRawIntBits() to 
> check for -0.0"
>     http://cr.openjdk.java.net/~darcy/7002594.0/
>
> Besides addressing the reported issues with max/min, I also review the 
> other uses of those methods in java.lang.* and added a comment or 
> two.  While looking over sun/misc/FpUtils.java, I took the opportunity 
> to update the javadoc style.
>
> Thanks,
>
> -Joe

Looks fine.

I just wonder why twoToTheDoubleScaleUp and twoToTheDoubleScaleDown in 
FpUtils
aren't real constants (static final).

Rémi



More information about the core-libs-dev mailing list