review of simple pack200 fix

Mike Duigou mike.duigou at oracle.com
Wed Dec 15 23:10:22 UTC 2010


Under what circumstances is null returned and why is it safe to ignore it? Is the handling of null related to the lack of a default label on the switch? ie. It is intentional that action is only taken with the 3 specified commands and null is just in the set of cmd values requiring no special action.

It makes me nervous whenever I see "pretend this never happened" handling for null.

Mike

On Dec 15 2010, at 14:45 , Kumar Srinivasan wrote:

> Hi,
> 
> Could you please review this simple  fix, it guards the switch value from a null.
> 
> http://cr.openjdk.java.net/~ksrini/7007157/webrev.00/
> 
> Thanks
> Kumar
> 
> 
> 




More information about the core-libs-dev mailing list