review of simple pack200 fix

[Kumar Srinivasan]

On 12/15/2010 3:10 PM, Mike Duigou wrote:
> Under what circumstances is null returned and why is it safe to ignore it? Is the handling of null related to the lack of a default label on the switch? ie. It is intentional that action is only taken with the 3 specified commands and null is just in the set of cmd values requiring no special action.
The latter ie. the 3 specified commands,  if null continue with the 
processing with no special
action, I have asked for a clarification of the behavior of nulls in the 
switch statement the
current stand from the coin folks is that a value for null will throw an 
NPE.

Kumar

> It makes me nervous whenever I see "pretend this never happened" handling for null.
>
> Mike
>
> On Dec 15 2010, at 14:45 , Kumar Srinivasan wrote:
>
>> Hi,
>>
>> Could you please review this simple  fix, it guards the switch value from a null.
>>
>> http://cr.openjdk.java.net/~ksrini/7007157/webrev.00/
>>
>> Thanks
>> Kumar
>>
>>
>>