Review request for 6924497: HotSpotDiagnosticsMXBean.getDiagnosticOptions throws NPE
Mandy Chung
Mandy.Chung at Sun.COM
Tue Feb 9 05:36:12 UTC 2010
Daniel D. Daugherty wrote:
> Mandy Chung wrote:
>> Dan,
>>
>> Can you review the fix for:
>> 6924497: HotSpotDiagnosticsMXBean.getDiagnosticOptions throws NPE
>>
>> Webrev at:
>> http://cr.openjdk.java.net/~mchung/6924497/webrev.00/
> src/share/classes/sun/management/Flag.java
> line 95 - I don't local var 'c' is needed here or on line 99.
>
It was used for verification. It's no longer needed and I'll update it.
> src/share/native/sun/management/Flag.c
> No comments.
>
Thanks for the review.
Mandy
> I'll be on the look out for the VM fix also.
>
> Dan
>
>
>
>
>>
>> The VM fix for 6898160 updates the jmm_GetVMGlobals function to
>> filter out unsupported type and the returning array may contain null
>> elements. The sun.management.Flag class needs to check for null
>> elements and handle unsupported types gracefully.
>>
>> Thanks
>> Mandy
>>
More information about the core-libs-dev
mailing list