Need reviewer for forward port of 6815768 (File.getXXXSpace) and 6815768 (String.hashCode)

Kelly O'Hair Kelly.Ohair at Sun.COM
Thu Feb 25 18:19:26 UTC 2010


Looks fine to me.

-kto

On 2/25/10 9:51 AM, Alan Bateman wrote:
>
> There are two fixes in Sun's proprietary jdk6 updates that should also
> be fixed in OpenJDK.
>
> The first one is that the File.getXXXSpace methods use statvfs instead
> of statvfs64 and so fail on 32-bit Solaris and Linux with very large
> file systems. The webrev is here:
> http://cr.openjdk.java.net/~alanb/6815768/webrev.00/
> The GetXSpace test already covers these methods and an additional test
> isn't required.
>
> The second one is a scalability fix to String.hashCode to avoid storing
> the hash code of empty strings. The webrev with the change is here:
> http://cr.openjdk.java.net/~alanb/6815768/webrev/
>
> Thanks,
> Alan.



More information about the core-libs-dev mailing list